[Translation] added method to expose collected message #8597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Grygir
commented
Jul 29, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | this component don't have docs |
[Translation] added method to expose collected message
|
A use case for this would be using translations in javascript. There already exist few bundles implementing this even though we're not exposing the messages in the translator (see JsI18nBundle or BazingaExposeTranslationBundle for examples). |
| /** | ||
| * Messages exposing | ||
| * | ||
| * Collects all messages for corresponded domains and locale, |
|
also your assert "this component does not have docs" is not accurate https://github.com/symfony/symfony-docs/tree/master/components/translation as you can see this is perfect to document things another thing is for in the case of a feature it would be ideal to have a paragraph or two explaining what you did on the code even though if it is evident, it helps guide what you are working on and explain things to others 👶 |
|
Closing as there's an updated version of this PR: #9859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.