[Console] Added more semantic commands to detect verbosity #8640
Conversation
lyrixx
commented
Aug 2, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| @@ -98,6 +98,31 @@ public function getVerbosity() | |||
| return $this->verbosity; | |||
| } | |||
|
|
|||
| public function isVerbosityQuiet() | |||
| { | |||
| return static::VERBOSITY_QUIET === $this->verbosity; | |||
There was a problem hiding this comment.
I used to use static everywhere ;)
There was a problem hiding this comment.
there should be a use case to use static
There was a problem hiding this comment.
I changed to self, but Why did you said that ? static is slower than self ?
There was a problem hiding this comment.
The meaning is different you know. Its like private vs protected.
There was a problem hiding this comment.
I thought it was only for LSB. Can you tell me more about this private vs protected ?
There was a problem hiding this comment.
Yes when using LSB you indirectly expose an extension point (similar to protected methods instead of private). And I don't see why somebody would want to override these constants in subclasses. So there is no need to expose this extension point without use case.
| Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a
| ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#8640 | License | MIT | Doc PR |