Skip to content

Adapt security collector template name to webprofiler conventions #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adapt security collector template name to webprofiler conventions #8666

wants to merge 1 commit into from

Conversation

hacfi
Copy link
Contributor

@hacfi hacfi commented Aug 5, 2013

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets fabpot/Twig#1156
License MIT

Debugging the issue I noticed that the @webprofiler templates use a different convention than the @SecurityBundle collector template.

This is a quick fix for symfony.

To allow the conventions most bundles use the Twig_Loader_Filesystem needs to be updated instead.

@hacfi hacfi closed this Aug 5, 2013
@hacfi hacfi deleted the security_profiler_tpl branch August 5, 2013 08:19
@fabpot
Copy link
Member

fabpot commented Aug 5, 2013

Why have you closed this one? It actually makes sense to merge it.

@hacfi
Copy link
Contributor Author

hacfi commented Aug 5, 2013

@fabpot I thought it makes more sense to merge #8672..will reopen.

Should I do the PR against 2.2, 2.3 or master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants