[Process] Fix #8739 #8740
Closed
[Process] Fix #8739 #8740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the ticket, you say that the issue is also present in 2.1. Why not fix 2.2 instead then? |
| @@ -254,7 +271,7 @@ public function testStatus() | |||
|
|
|||
| public function testStop() | |||
| { | |||
| $process = $this->getProcess('php -r "while (true) {}"'); | |||
There was a problem hiding this comment.
this is part of this commit romainneutron@923fc58
On my computer, zombie processes might have remain in case of unit test failure.
It happend that some infinite loops were running and slowing down my system. A ps call alerted me that many (~100) php -r "while (true) {}" were running after half an hour debugging things.
I propose to change these. As tests pass and nothing changed in the way we test things, I think it's a better idea to have these commands instead of the infinite loops for symfony/process developers.
|
sure, boss |
|
Closed in favor of #8741 |
This was referenced Aug 13, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fix to #8739. Whenever a call is done to to any non-blocking methods (
Process::isRunning,Process::isStopped,Process::isTerminated,Process::getStatus,Process::getPid...), buffers are read, and callback executed.Such code will now work :