@srcspider Can you try with the latest version as I'm not able to reproduce it.

I've added this test:

    public function testFormWithId()
    {
        $dom = new \DOMDocument();
        $dom->loadXML('<?xml version="1.0" encoding="UTF-8"?><root><form id="form"><input type="submit" /></form></root>');

        // $nodes = $dom->getElementById('form');
        // $this->assertNotNull($nodes);
        $nodes = $dom->getElementsByTagName('input');

        $form = new Form($nodes->item(0), 'http://example.com');
    }

And even if the getElementById() does not work (commented code), the form works fine.

You can't expect the form to work with getElementById() failing when the form input could very well be outside the form (and is in 90% of my use cases)

<?xml version="1.0" encoding="UTF-8"?>
<root>
    <form id="form1" method="GET">
        <input type="hidden" name="submitted" value="form1"/>
    </form>
    <input form="form1" type="submit"/>
</root>

@srcspider I still don't get it. If you try to use the code you mentioned as HTML, it works perfectly fine. And if you are using XHTML, it's not valid.

@fabpot The point was not that the code is invalid html (with regard to xml, it only looks like that because I just altered your example to illustrate the difference).

The example is in response to what you previously said,

And even if the getElementById() does not work (commented code), the form works fine.

That only applies to example like the one you gave where the form encapsulates the fields. In examples like the one I gave you where the field is outside the form and linked to the form via the form attribute if getElementById() fails obviously the form fails.

I have tried with the submit button outside of the form and it definitely works if the doctype is HTML5.

So, I still don't have any valid example that actually does not work. The code you give is wrong as you cannot use a submit button outside of a form in XHTML.

@fabpot

So, I still don't have any valid example that actually does not work. The code you give is wrong as you cannot use a submit button outside of a form in XHTML.

I'll take it you're referring to the 4.1 XHTML specification and don't support HTML5, since that's a valid XML and there is no rule that submit buttons can't have a form attribute association. Specificiation: http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fae-form

I can't give you a perfect example since I'm too high on the dependency chain to actually have the full reason why your system, while used by various other projects, fails (and dont ask me to ask them, I did, they pointed the finger at you). I can only tell you what part of it fails, why it fails and how you can patch it so it doesn't fail anymore, not the exact reasons and pieces why it reaches the fail state.

I also don't use symphony, and have dropped the parts in the tools that use this system, so it's not worth my time to dig for days to find you a perfect example.

The example I've given you is a "test" on how to see under what circumstances it fail, not a test for the actual bug in your system. Here's a single block version in case reading the xml from another file was confusing:

<?php

$doc = new DomDocument;
$doc->validateOnParse = true;

$doc->loadXML
    (
        '<?xml version="1.0" encoding="UTF-8"?>
        <root>
            <form id="testform1">
                <input type="submit" />
            </form>
        </root>
        '
    );

// the getElementById is important!
if ($doc->getElementById('testform1') === null)
{
    throw new \Exception('Failed');
}

is this PR already merged? @fabpot

No, it's not merged yet and from what I see this won't happen if we don't have a failing test case for this issue.

@OskarStark have you experienced this issue yourself?

@jakzal no, but the ticket is very old, thought that this one could be closed

I agree. Someone can open a new pull request if they are able to provide a proper test case.

@xabbuh thank you