[Console] make parent constructor test more reliable #9244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,9 +80,6 @@ public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN') | |||
| { | |||
| $this->name = $name; | |||
| $this->version = $version; | |||
| $this->catchExceptions = true; | |||
| $this->autoExit = true; | |||
| $this->commands = array(); | |||
There was a problem hiding this comment.
The changes related to moving the default values from the constructor to the properties should be reverted as it's not related to this PR and it's not consistent with the framework way of doing things.
There was a problem hiding this comment.
It's related because the original implementation is broken with this change. So it shows that the original implementation is not reliable.
Also in almost all other classes in symfony we initiliaze booleans and arrays at the property definitions. Just look in the routing or form component. You must have confused something here.
it also fixes the test since f2b60e9 and improves phpdoc
using possesive quantifier
|
Rebased |
|
@fabpot ping |
1 similar comment
|
@fabpot ping |
fabpot
added a commit
that referenced
this pull request
Oct 31, 2013
…ion) This PR was merged into the master branch. Discussion ---------- [Console] make parent constructor test more reliable | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixes | #9186 , f2b60e9 | Tests pass? | yes | license? | MIT It also fixes the test since f2b60e9 and improves phpdoc The second commit improves regex performance to validate name (using possesive quantifier). I did some basic performance tests http://3v4l.org/PuvuL The new regex only takes 1/3 of the time compared to the old one! Commits ------- 5798029 [Console] improve regex performance to validate name 22b09ce [Console] make parent constructor test more reliable
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fixes the test since f2b60e9 and improves phpdoc
The second commit improves regex performance to validate name (using possesive quantifier).
I did some basic performance tests http://3v4l.org/PuvuL
The new regex only takes 1/3 of the time compared to the old one!