[Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time #9453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to date & time sub widgets
|
ping @bschussek |
|
I just notice it has been removed in ac69394 but I don't really get why? |
|
ping @bschussek |
|
@webmozart I would really like to have feedback about this one :) |
|
Thanks for your patience, @egeloen. I merged this into 2.3. |
webmozart
added a commit
that referenced
this pull request
Sep 25, 2014
…e_parameters to date & time (egeloen) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9453). Discussion ---------- [Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR propagates the `invalid_message` & `invalid_message_parameters` in the datetime form type to the date & time sub form types. It allows to have the good error message if you use something else than the `single_widget` widget. I have looked the `DateTimeTypeTest` but I have not found tests related to this kind of propagation, so for now I have not added tests yet. Commits ------- ea4ae74 [Form][DateTime] Propagate invalid_message & invalid_message parameters to date & time sub widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates the
invalid_message&invalid_message_parametersin the datetime form type to the date & time sub form types. It allows to have the good error message if you use something else than thesingle_widgetwidget.I have looked the
DateTimeTypeTestbut I have not found tests related to this kind of propagation, so for now I have not added tests yet.