Skip to content

Fixed typos #9518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2013
Merged

Fixed typos #9518

merged 1 commit into from
Nov 19, 2013

Conversation

pborreli
Copy link
Contributor

No description provided.

@cordoval
Copy link
Contributor

I wonder if the throws are good though 👶

fabpot added a commit that referenced this pull request Nov 19, 2013
This PR was merged into the master branch.

Discussion
----------

Fixed typos

Commits
-------

8ebf7c5 Fixed typos
@fabpot fabpot closed this Nov 19, 2013
@fabpot fabpot merged commit 8ebf7c5 into symfony:master Nov 19, 2013
@pborreli pborreli deleted the typo-bi branch November 19, 2013 18:40
@pborreli
Copy link
Contributor Author

@fabpot why I don't see my name in pulse anymore ? are you removing authorship when PR are considered as minor ?

@fabpot
Copy link
Member

fabpot commented Nov 19, 2013

@pborreli I don't even know how I could even do that. And anyway, I have other more interesting things to do.

@pborreli
Copy link
Contributor Author

@fabpot I just try to understand where the "minor.." comes from, no offence .. and glad to hear you have interesting things to do btw.

@stof
Copy link
Member

stof commented Nov 19, 2013

@pborreli minor is in the merge commit message. It is not replacing your own commit

@pborreli
Copy link
Contributor Author

@stof thanks for your answer, got it now.

@stof
Copy link
Member

stof commented Nov 19, 2013

And for pulse, as the latest data appearing in it are 38 minutes old, I suggest that it may be related to some caching of the page instead of refreshing it for each change in the repo

@pborreli
Copy link
Contributor Author

or maybe it's because my commit is more than 3 days old because we see others contributor who just made a PR today

@pborreli
Copy link
Contributor Author

anyway that has no importance, was just simple curiosity, sry for the spam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants