Skip to content

Add missing dependency to expression-language #9531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2013

Conversation

armetiz
Copy link
Contributor

@armetiz armetiz commented Nov 19, 2013

Add missing dependency, without this dependency, PHPUnit can't run successfully.

@stof
Copy link
Member

stof commented Nov 19, 2013

for which test is it using the expression language ?

@armetiz
Copy link
Contributor Author

armetiz commented Nov 19, 2013

The Symfony\Bridge\Doctrine\ExpressionLanguage\DoctrineParserCache have a dependency to :

  • Symfony\Component\ExpressionLanguage\ParsedExpression
  • Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface

@stof
Copy link
Member

stof commented Nov 19, 2013

oh, I forgot there was a parser cache implementation in the bridge, right

fabpot added a commit that referenced this pull request Nov 19, 2013
This PR was merged into the master branch.

Discussion
----------

Add missing dependency to expression-language

Add missing dependency, without this dependency, PHPUnit can't run successfully.

Commits
-------

4206e98 Add missing dependency to expression-language
@fabpot fabpot merged commit 4206e98 into symfony:master Nov 19, 2013
@armetiz armetiz deleted the patch-validator-composer branch November 19, 2013 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants