[Console][ProgressHelper] Added estimated time and memory usage #9572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -26,7 +26,7 @@ class ProgressHelper extends Helper | |||
| const FORMAT_VERBOSE = ' %current%/%max% [%bar%] %percent%% Elapsed: %elapsed%'; | |||
There was a problem hiding this comment.
You can add the memory indicator to FORMAT_VERBOSE.
|
Can you submit 2 different PRs for your 2 features instead of mixing the estimated time and the memory usage together ? |
|
Do you want memory usage in FORMAT_VERBOSE and estimated in FORMAT_VERBOSE ? |
|
@lsv the memory usage and the estimated time are 2 different features for the progress helper. So they should be in 2 separate PRs (which can be reviewed and merged separately) instead of being in a single PR (forcing us to accept both or none). |
|
Closing this is favor of the 2 other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #9560
How to use it.
And the output will be something like this
The estimated is actually quite close to the time it took for my command (it took 5 min and 53 sec) - but of course it requires that all elements take the same time to execute.
The estimated time will be recalculated on each advance() (same time elapsed gets updated)
I havent quite figured out in which format the estimated should be in, so I only added it to FORMAT_VERBOSE_NOMAX, but should maybe be added to others as well?