[Console] Verbose long option value does not work in ArgvInput #9576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased. |
|
Closing this PR as it only contains a test that cannot be merged. I've created an issue about this instead with a reference to this code for whomever might want to work on a fix (see #10487). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just add a test and opens the issue, which relates #9566 to start a discussion about the problem.
I added a test for long option value. Which does not work for
ArgvInput. So syntaxis not working since 2.3.
What can be done:
But there a low chance of user problems still exists if they rely on this option in ArrayInput (long verbose option value works for
ArrayInputwithVALUE_NONEbecause it does not check that value is acceptable, and does not work forStringorArgvbecause of this check).The another way is to add some more hacks to fix this support. But any change in this way have to be a hack, because option should stay to be
VALUE_NONEfor BC.