[Console] fix #9325 extend table helper to have a row divider #9680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,6 +263,7 @@ public static function createFromGlobals() | |||
| $request->request = new ParameterBag($data); | |||
| } | |||
|
|
|||
| if (0 === strpos()) | |||
There was a problem hiding this comment.
woah! removing immediately
|
👍 |
|
You must create a doc pr before merging this. (let's be strict again about that topic) |
|
ok @wouterj i will work on it |
|
@wouterj done |
|
Maybe you could squash your commits to have only one relevant. |
|
@hhamon done |
|
bump @fabpot , all good or shall i rebase? |
|
@fabpot rebased |
|
now i want to cook that bot @fabbot-io
@fabpot ^^ This PR is 👍 |
|
Closing in favor of #10365 |
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…bpot) This PR was merged into the 2.5-dev branch. Discussion ---------- [Console] deprecated TableHelper in favor of Table | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #9788, #9680, #9325 | License | MIT | Doc PR | symfony/symfony-docs#3627 This PR makes the Table helper stateless. It also adds a way to define global styles and to change/tweak existing styles easily. The second commit adds the possibility to add a separator anywhere in the table output. Commits ------- 21784ce [Console] make it possible to pass a style directly to Table::setStyle() 14caaec [Console] added the possibility to insert a table separator anywhere in a table output 39c495f [Console] deprecated TableHelper in favor of Table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the ability to insert divider rows within a table.