Skip to content

[Finder] Add GLOB_BRACE support in Finder::in() method #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Finder] Add GLOB_BRACE support in Finder::in() method #9705

wants to merge 1 commit into from

Conversation

brikou
Copy link
Contributor

@brikou brikou commented Dec 5, 2013

before

$finder->files()->in([
    'My/First/Directory',
    'My/Second/Directory',
    'My/Third/Directory',
]);

after

$finder->files()->in('My/{First,Second,Third}/Directory');
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@cordoval
Copy link
Contributor

cordoval commented Dec 5, 2013

and tests?

@cordoval cordoval mentioned this pull request Dec 5, 2013
Closed
@jakzal
Copy link
Contributor

jakzal commented Dec 5, 2013

@brikou could you add some tests? Might be similar to the ones for the GLOB_DIR.

@brikou
Copy link
Contributor Author

brikou commented Dec 5, 2013

@jakzal @cordoval I'll add some test soon and then ping you back 👍

@cordoval
Copy link
Contributor

cordoval commented Dec 5, 2013

if you don't by next week then we will take it on hacking day 👶 sounds like a good test to write

@brikou
Copy link
Contributor Author

brikou commented Dec 14, 2013

@cordoval really great if someone can works on it at the symfonycon...

@jakzal jakzal mentioned this pull request Jan 1, 2014
Merged
@jakzal
Copy link
Contributor

jakzal commented Jan 1, 2014

Closing in favor of #9926 which includes a test case and a changelog update.

@jakzal jakzal closed this Jan 1, 2014
@brikou
Copy link
Contributor Author

brikou commented Jan 1, 2014

@jakzal great! Thx

fabpot added a commit that referenced this pull request Jan 2, 2014
@fabpot
feature #9926 [Finder] Added GLOB_BRACE support in Finder::in() metho…
2c059ee 
…d (jakzal)

This PR was merged into the 2.5-dev branch.

Discussion
----------

[Finder] Added GLOB_BRACE support in Finder::in() method

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9705
| License       | MIT
| Doc PR        | ~

**before**

```php
$finder->files()->in([
    'My/First/Directory',
    'My/Second/Directory',
    'My/Third/Directory',
]);
```

**after**

```php
$finder->files()->in('My/{First,Second,Third}/Directory');
```

Commits
-------

e2698fc [Finder] Included GLOB_BRACE support in the CHANGELOG.
30814d3 [Finder] Added a test case for the GLOB_BRACE in Finder:in().
da67f5d [Finder] Added GLOB_BRACE support in Finder::in() method
@piotrpasich
Copy link

@brikou I think it might be used with pipes, not commas

$finder->files()->in('My/{First|Second|Third}/Directory');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Finder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brikou @cordoval @jakzal @piotrpasich