[DomCrawler] xml not being filtered correctly (added failing test) #9732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I remove |
|
ping @jakzal |
|
The test also passes if the filter string is I just now discovered the changelog for this component (didn't know each component had their own). I see the namespace used to be removed, but is no longer. Is there anything that can be done to revert this BC break? |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2013
This PR was squashed before being merged into the 2.4 branch (closes #9771). Discussion ---------- Crawler default namespace fix | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9732, #6650 | License | MIT | Doc PR | symfony/symfony-docs/pull/2979 Fix backwards compatibility of xml namespaces for having only one default namespace. Commits ------- cfff054 Crawler default namespace fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after upgrading a project to 2.4, a bunch of functionality tied to the DomCrawler was not working anymore. Specifically with regards to filtering XML.
This test passes in v2.3.7.