ubot detected some small issues in this pull request.

You can make the modifications by hand or run the following command from the repository root directory:

curl http://ubot.io/patch/symfony/symfony/9771.diff | patch -p0

diff -ru src/Symfony/Component/DomCrawler/Crawler.php src/Symfony/Component/DomCrawler/Crawler.php
--- src/Symfony/Component/DomCrawler/Crawler.php    2013-12-15 09:28:56.199122873 +0000
+++ src/Symfony/Component/DomCrawler/Crawler.php    2013-12-15 09:28:56.535122873 +0000
@@ -201,7 +201,7 @@
     public function addXmlContent($content, $charset = 'UTF-8')
     {
         // remove the default namespace if it's the only namespace to make XPath expressions simpler
-        if(!preg_match('/xmlns:/', $content)) {
+        if (!preg_match('/xmlns:/', $content)) {
             $content = str_replace('xmlns', 'ns', $content);
         }

ping @jakzal

@fabpot I've helped with this PR during the hack day so I'm 👍

This seems to be the only way to revert the BC break partially. This PR brings back the hack which we used to have, but only for the scenario when there's a single namespace and it is a default namespace. So it simplifies filtering for single namespace documents and keeps it flexible for multiple namespace ones.

It might be worth documenting. I'll send a PR if we all agree it's good to merge.

@jakzal You're the boss here, so let's document this properly.
@crudecki Can you rebase your PR to remove the merge commit and avoid any non-related commits?

@crudecki also, ubot suggest a small CS fix ;)

I think we should also update the CHANGELOG.md:

`Crawler::addXmlContent()` removes the default document namespace again if it's an only namespace.

I've removed the unnecessary merge

@crudecki Great, can you add the suggested change in the CHANGELOG?

Done it through Github interface, hope this is fine.

Doing so through github interface results in a new PR: #9800

@crudecki Go at this page: https://github.com/crudecki/symfony/blob/crawlerDefaultNamespaceFix/src/Symfony/Component/DomCrawler/CHANGELOG.md and edit file there, after that it will be in this PR so you can close #9800.

Done : ) help in getting started with contributing much appreciated : ) thanks

🍺