Skip to content

[HttpFoundation] [Response] Use constants for HTTP codes #9808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] [Response] Use constants for HTTP codes #9808

wants to merge 1 commit into from

Conversation

lucasmichot
Copy link

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This code replaces numerical HTTP codes by their constant equivalent.

@fabpot
Copy link
Member

fabpot commented Dec 18, 2013

It's not worth it internally.

@fabpot fabpot closed this Dec 18, 2013
@lucasmichot lucasmichot deleted the fix/response-constants branch December 18, 2013 09:51
romainneutron pushed a commit to romainneutron/symfony that referenced this pull request Mar 13, 2014
see: symfony#9808 (comment) (+1 squashed commit)
Squashed commits:
[7566e01] Use self:: instead of static:: - and I should consider stopping writhing code at midnight after a long workday ;) (+1 squashed commit)
Squashed commits:
[ea1e670] hasPreconditionFailed() and setPreconditionFailed()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants