Skip to content

[Validator] Moved DoctrineCache to Doctrine Bridge #9898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

florianv
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

As per @stof remark on #9892 the DoctrineCache class should be located in the Doctrine Bridge.

@fabpot
Copy link
Member

fabpot commented Dec 30, 2013

Not sure this is a good idea. As this is the only/main way to enable the cache, it's more than just integrating Doctrine with the Validator. So, I'm -1.

@florianv
Copy link
Contributor Author

@fabpot There is a similar case with DoctrineParserCache (https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/ExpressionLanguage/DoctrineParserCache.php).
Should we create an issue to move this class to the ExpressionLanguage component and deprecate the ArrayParserCache (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/ExpressionLanguage/ParserCache/ArrayParserCache.php) ? To keep consistency.

@fabpot
Copy link
Member

fabpot commented Dec 30, 2013

No, both cases are quite different if you ask me.

@florianv florianv closed this Jan 14, 2014
@florianv florianv deleted the validator-cache branch January 26, 2014 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants