[Form] Created FormErrorBag (Approach 2) #9914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fully BC with returning an array and it deprecates Form::getErrorsAsString()
It's now an IteratorAggregate with ArrayAccess. At normal use, it only returns the root errors. When calling FormErrorBag#getAllErrors() it will return a RecursiveArrayIterator, iterating over all form errors.
|
you need to clone the FormErrorBag when cloning the Form as it is an object now. Otherwise errors will be shared between both forms |
|
|
||
| // for BC | ||
| if (is_array($childrenErrors)) { | ||
| $_collection = new FormErrorBag(); |
There was a problem hiding this comment.
we don't use the leading undescore in Symfony
|
I think adding the errors to the bags is problematic, because now we store the errors in two different locations which we need to synchronize. I found a better and simpler approach using just iterators now that I'm going to post as PR shortly. That approach is somewhat similar to yours, but uses a different perspective (temporary iterators instead of permanent bags). |
|
replaced by #9918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #9099 :
The only BC break in this PR is checking it with is_array.
It turns out that the previous approach, using recursive iterators, couldn't work in practise. That's why I introduce, with the help of @igorw, a new approach. When using it normally, it can be accessed as an array and when iterating it will iterate only over the root errors (this is BC). When calling
FormErrorBag->getAllErrors()aRecursiveArrayIteratoris returned, iterating over all errors.