Merge branch '4.3' into 4.4

javiereguiluz · javiereguiluz · commit d23e5ee7954b · 2019-10-16T08:51:14.000+02:00
* 4.3:
  Minor code refactor
  Update Form Page
  Update Configuring Symfony page
  Added namespace for example
  Added a detail for getCrawler return.
  [Cache] Fixed some method names
  Fix EvolvableLink attribute
diff --git a/components/cache/cache_pools.rst b/components/cache/cache_pools.rst
@@ -65,11 +65,11 @@ and deleting cache items using only two methods and a callback::
 
 Out of the box, using this interface provides stampede protection via locking
 and early expiration. Early expiration can be controlled via the third "beta"
-argument of the :method:`Symfony\\Contracts\\Cache\\CacheInterface::get()` method.
+argument of the :method:`Symfony\\Contracts\\Cache\\CacheInterface::get` method.
 See the :doc:`/components/cache` article for more information.
 
 Early expiration can be detected inside the callback by calling the
-:method:`Symfony\\Contracts\\Cache\\ItemInterface::isHit()` method: if this
+:method:`Symfony\\Contracts\\Cache\\ItemInterface::isHit` method: if this
 returns ``true``, it means we are currently recomputing a value ahead of its
 expiration date.
 
diff --git a/configuration.rst b/configuration.rst
@@ -796,6 +796,8 @@ parameters at once by type-hinting any of its constructor arguments with the
 :class:`Symfony\\Component\\DependencyInjection\\ParameterBag\\ContainerBagInterface`::
 
     // src/Service/MessageGenerator.php
+    namespace App\Service;
+    
     // ...
 
     use Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface;
diff --git a/forms.rst b/forms.rst
@@ -199,6 +199,8 @@ use the ``createForm()`` helper (otherwise, use the ``create()`` method of the
 ``form.factory`` service)::
 
     // src/Controller/TaskController.php
+    namespace App\Controller;
+    
     use App\Form\Type\TaskType;
     // ...
 
@@ -229,6 +231,8 @@ So, while not always necessary, it's generally a good idea to explicitly specify
 the ``data_class`` option by adding the following to your form type class::
 
     // src/Form/Type/TaskType.php
+    namespace App\Form\Type;
+    
     use App\Entity\Task;
     use Symfony\Component\OptionsResolver\OptionsResolver;
     // ...
@@ -519,6 +523,8 @@ object.
     .. code-block:: php
 
         // src/Entity/Task.php
+        namespace App\Entity;
+        
         use Symfony\Component\Validator\Constraints\NotBlank;
         use Symfony\Component\Validator\Constraints\Type;
         use Symfony\Component\Validator\Mapping\ClassMetadata;
@@ -555,6 +561,8 @@ the form in the controller you can pass custom options to it as the third option
 argument of ``createForm()``::
 
     // src/Controller/TaskController.php
+    namespace App\Controller;
+    
     use App\Form\Type\TaskType;
     // ...
 
@@ -579,6 +587,8 @@ If you try to use the form now, you'll see an error message: *The option
 options they accept using the ``configureOptions()`` method::
 
     // src/Form/Type/TaskType.php
+    namespace App\Form\Type;
+    
     use Symfony\Component\OptionsResolver\OptionsResolver;
     // ...
 
@@ -758,6 +768,8 @@ If you want to modify this, use the :method:`Symfony\\Component\\Form\\FormFacto
 method::
 
     // src/Controller/TaskController.php
+    namespace App\Controller;
+    
     use App\Form\TaskType;
     use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 
diff --git a/templates.rst b/templates.rst
@@ -188,6 +188,7 @@ Consider the following routing configuration:
     .. code-block:: php-annotations
 
         // src/Controller/BlogController.php
+        namespace App\Controller;
 
         // ...
         use Symfony\Component\Routing\Annotation\Route;
@@ -421,6 +422,8 @@ you only need to add an argument in the service constructor and type-hint it wit
 the :class:`Twig\\Environment` class::
 
     // src/Service/SomeService.php
+    namespace App\Service;
+    
     use Twig\Environment;
 
     class SomeService
diff --git a/testing.rst b/testing.rst
@@ -535,6 +535,7 @@ You can also get the objects related to the latest request::
     // the BrowserKit response instance
     $response = $client->getInternalResponse();
 
+    // the Crawler instance
     $crawler = $client->getCrawler();
 
 Accessing the Container
diff --git a/web_link.rst b/web_link.rst
@@ -170,7 +170,9 @@ You can also add links to the HTTP response directly from controllers and servic
 
             // alternative if you don't want to use the addLink() shortcut
             $linkProvider = $request->attributes->get('_links', new GenericLinkProvider());
-            $request->attributes->set('_links', $linkProvider->withLink(new Link('preload', '/app.css', ['as' : 'style'])));
+            $request->attributes->set('_links', $linkProvider->withLink(
+                (new Link('preload', '/app.css'))->withAttribute('as', 'style')
+            ));
 
             return $this->render('...');
         }

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,9 @@ You can also add links to the HTTP response directly from controllers and servic`
`170`	`170`
`171`	`171`	`// alternative if you don't want to use the addLink() shortcut`
`172`	`172`	`$linkProvider = $request->attributes->get('_links', new GenericLinkProvider());`
`173`		`- $request->attributes->set('_links', $linkProvider->withLink(new Link('preload', '/app.css', ['as' : 'style'])));`
	`173`	`+ $request->attributes->set('_links', $linkProvider->withLink(`
	`174`	`+ (new Link('preload', '/app.css'))->withAttribute('as', 'style')`
	`175`	`+ ));`
`174`	`176`
`175`	`177`	`return $this->render('...');`
`176`	`178`	`}`