minor #10552 Supports() must return a boolean (darrylhein)

javiereguiluz · javiereguiluz · commit f9cb39c71900 · 2018-10-25T08:41:22.000+02:00
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10552). Discussion ---------- Supports() must return a boolean The code docs say "null" when it should be false. Commits ------- 4052f6a supports() must return a boolean
diff --git a/security/guard_authentication.rst b/security/guard_authentication.rst
@@ -590,7 +590,7 @@ are two possible fixes:
         public function supports(Request $request)
         {
     +         // if there is already an authenticated user (likely due to the session)
-    +         // then return null and skip authentication: there is no need.
+    +         // then return false and skip authentication: there is no need.
     +         if ($this->security->getUser()) {
     +             return false;
     +         }

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ are two possible fixes:`
`590`	`590`	`public function supports(Request $request)`
`591`	`591`	`{`
`592`	`592`	`+ // if there is already an authenticated user (likely due to the session)`
`593`		`- + // then return null and skip authentication: there is no need.`
	`593`	`+ + // then return false and skip authentication: there is no need.`
`594`	`594`	`+ if ($this->security->getUser()) {`
`595`	`595`	`+ return false;`
`596`	`596`	`+ }`