Skip to content

Supports() must return a boolean #10552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Supports() must return a boolean #10552

wants to merge 1 commit into from

Conversation

darrylhein
Copy link
Contributor

The code docs say "null" when it should be false.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 25, 2018
@javiereguiluz
Copy link
Member

Good catch! This was introduced accidentally after the recent security docs revamp. We merged it in 3.4 branch.

javiereguiluz added a commit that referenced this pull request Oct 25, 2018
@javiereguiluz
minor #10552 Supports() must return a boolean (darrylhein)
f9cb39c 
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10552).

Discussion
----------

Supports() must return a boolean

The code docs say "null" when it should be false.

Commits
-------

4052f6a supports() must return a boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@darrylhein @javiereguiluz @carsonbot