Skip to content

Twig: Lazy loaded extensions example does not work in twig<1.35 #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhujer opened this issue Nov 6, 2019 · 1 comment
Closed

Twig: Lazy loaded extensions example does not work in twig<1.35 #12597

mhujer opened this issue Nov 6, 2019 · 1 comment
Labels
bug Status: Needs Review

Comments

@mhujer
Copy link
Contributor

mhujer commented Nov 6, 2019

Documentation states:

New in version 1.26: Support for lazy-loaded extensions was introduced in Twig 1.26.

However the interface Twig\Extension\RuntimeExtensionInterface which is included in the example is not available until Twig 1.35 (twigphp/Twig@6f08f57)
@javiereguiluz javiereguiluz mentioned this issue Dec 5, 2019
Merged
@javiereguiluz
Copy link
Member

@mhujer great catch! Thanks a lot for reporting this bug. We're fixing it in #12766.

wouterj added a commit that referenced this issue Dec 8, 2019
@wouterj
minor #12766 Fixed the minimum Twig version needed for lazy extension…
58ef51e 
…s (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Fixed the minimum Twig version needed for lazy extensions

Fixes #12597.

Commits
-------

234c9f9 Fixed the minimum Twig version needed for lazy extensions
@wouterj wouterj closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @mhujer @wouterj @carsonbot