Skip to content

[SecurityBundle] Wrong note about password encoders #12662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chalasr opened this issue Nov 23, 2019 · 0 comments
Closed

[SecurityBundle] Wrong note about password encoders #12662

chalasr opened this issue Nov 23, 2019 · 0 comments
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@chalasr
Copy link
Member

chalasr commented Nov 23, 2019

Good first issue:
In https://symfony.com/doc/3.4/reference/configuration/security.html#encoders, the first config block contains:

# PBKDF2 encoder using SHA512 hashing with default options
AppBundle\Entity\User: 'sha512'

Actually such config does not wire a PBKDF2 encoder but a MessageDigestPasswordEncoder which uses the hash() function.
(you'd need AppBundle\Entity\User: pbkdf2 for a PBKDF2 encoder with sha512 hash algo).
@javiereguiluz javiereguiluz added good first issue Ideal for your first contribution! (some Symfony experience may be required) help wanted Issues and PRs which are looking for volunteers to complete them. labels Nov 23, 2019
ThomasBerends pushed a commit to ThomasBerends/symfony-docs that referenced this issue Nov 23, 2019
Fixes symfony#12662
0726f1f
@ThomasBerends ThomasBerends mentioned this issue Nov 23, 2019
Merged
wouterj added a commit that referenced this issue Nov 23, 2019
@wouterj
minor #12665 #12662 [SecurityBundle] Wrong note about password encode…
d7adc5a 
…rs (Thomas Berends)

This PR was merged into the 3.4 branch.

Discussion
----------

#12662 [SecurityBundle] Wrong note about password encoders

Fixes #12662

#SymfonyHackday

Commits
-------

0726f1f Fixes #12662
@xabbuh xabbuh closed this as completed Nov 23, 2019
wouterj added a commit that referenced this issue Nov 23, 2019
@wouterj
Merge branch '3.4' into 4.3
ac9fbb2 
* 3.4:
  remove 'command' from execute argument
  Fixes #12662
wouterj added a commit that referenced this issue Nov 23, 2019
@wouterj
Merge branch '4.3' into 4.4
43dc280 
* 4.3:
  remove 'command' from execute argument
  Fixes #12662
  Fix typo in lock.rst
wouterj added a commit that referenced this issue Nov 23, 2019
@wouterj
Merge branch '4.4' into 5.0
d5c1688 
* 4.4:
  remove 'command' from execute argument
  Fixes #12662
  Fix typo in lock.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @chalasr