Skip to content

overwriting error controller should be updated for 4.4 #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonHeimberg opened this issue Jan 10, 2020 · 2 comments · Fixed by #13222
Closed

overwriting error controller should be updated for 4.4 #12920

SimonHeimberg opened this issue Jan 10, 2020 · 2 comments · Fixed by #13222
Labels
ErrorHandler
Milestone
4.4

Comments

@SimonHeimberg
Copy link
Contributor

SimonHeimberg commented Jan 10, 2020 •
edited
Loading

The article about customizing error pages [1] still mentions ExceptionController as base for a new error controller. But this class is depreacated in 4.4 (and removed in 5). But changing the class to
Symfony\\Component\\HttpKernel\\Controller\\ErrorController is not sufficient. The instructions for passing the debug flag do not match as well.

But do we advised to extend ErrorController, or maybe to set a custom service as error_renderer? But I do not get at all how selecting error_render works.

related: #12273

[1] https://symfony.com/doc/4.4/controller/error_pages.html#overriding-the-default-errorcontroller
@yceruto
Copy link
Member

yceruto commented Jan 10, 2020 •
edited
Loading

Hi @SimonHeimberg, you're right and we must remove the ExceptionController everywhere in this page and use ErrorController instead.

Let me know what you want to override exactly, so I can help you. It's likely that you don't need to override the ErrorController anymore, unless you want a different error system.

@xabbuh xabbuh added this to the 4.4 milestone Jan 17, 2020
@SimonHeimberg
Copy link
Contributor Author

@yceruto I do not need to change yet, I yust saw this while updateing to symfony 4

also related: #13071

@yceruto yceruto mentioned this issue Feb 22, 2020
Merged
@d4rkne55 d4rkne55 mentioned this issue Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ErrorHandler
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Remove the mention of TwigBundle\ExceptionController and extending doc yceruto/symfony-docs
3 participants
@xabbuh @yceruto @SimonHeimberg