Skip to content

[Console] Add support for true colors #13795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Jun 10, 2020 · 1 comment · Fixed by #14494
Closed

[Console] Add support for true colors #13795

fabpot opened this issue Jun 10, 2020 · 1 comment · Fixed by #14494
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
5.2

Comments

@fabpot
Copy link
Member

fabpot commented Jun 10, 2020

Q A
Feature PR symfony/symfony#36802
PR author(s) @fabpot
Merged in 5.2-dev
@xabbuh xabbuh added the Console label Jun 10, 2020
@xabbuh xabbuh added this to the 5.2 milestone Jun 10, 2020
@wouterj
Copy link
Member

wouterj commented Oct 17, 2020

This applies to https://symfony.com/doc/current/console/coloring.html

In there, we're saying "Available foreground and background colors are: black, red, green, yellow, blue, magenta, cyan and white.". This should be updated to say something like "any hex color is supported, besides that these named colors are supported:". And then also say something about "if the terminal doesn't support true colors, the nearest named color is used".

@wouterj wouterj added actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Oct 17, 2020
@freezy-sk freezy-sk mentioned this issue Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
5.2
Development

Successfully merging a pull request may close this issue.

Mention supported hex colors freezy-sk/symfony-docs
3 participants
@fabpot @wouterj @xabbuh