Skip to content

[FrameworkBundle] allow enabling the HTTP cache using semantic configur… #13881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Jun 22, 2020 · 4 comments · Fixed by #16402
Closed

[FrameworkBundle] allow enabling the HTTP cache using semantic configur… #13881

fabpot opened this issue Jun 22, 2020 · 4 comments · Fixed by #16402
Labels
FrameworkBundle Keep open
Milestone
5.2

Comments

@fabpot
Copy link
Member

fabpot commented Jun 22, 2020

Q A
Feature PR symfony/symfony#37351
PR author(s) @nicolas-grekas
Merged in 5.2-dev
@xabbuh xabbuh added this to the 5.2 milestone Jun 23, 2020
@wouterj
Copy link
Member

wouterj commented Oct 17, 2020 •
edited
Loading

I'm not sure here. The new method is significantly slower and there isn't yet any reason not to update public/index.php afaics (there is no Runtime component yet). So I'm leaning towards not yet documenting this feature.

cc @symfony/team-symfony-docs

@nicolas-grekas
Copy link
Member

I think the slowdown is irrelevant and that we should document the configuration and even recommend it.
We can of course continue to mention the PHP way, but this should be for advanced users.

About the slowdown, ppl that care should use Varnish. The difference between 2.1krps vs 1.7krps is nothing compared between Varnish vs HttpCache.

@nicolas-grekas
Copy link
Member

BTW, for clarity in case this is needed, the slowdown is only for a warm cache HttpCache of course.

@javiereguiluz javiereguiluz mentioned this issue Apr 22, 2021
Closed
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@xabbuh xabbuh added Keep open and removed Stalled labels Oct 20, 2021
@wouterj wouterj mentioned this issue Jan 16, 2022
Merged
@nicolas-grekas nicolas-grekas mentioned this issue Jan 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle Keep open
Projects
None yet
Milestone
5.2
Development

Successfully merging a pull request may close this issue.

Update section about http cache nicolas-grekas/symfony-docs
5 participants
@fabpot @nicolas-grekas @wouterj @xabbuh @carsonbot