[FrameworkBundle] allow enabling the HTTP cache using semantic configuration #37351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
674b3c1 to
8a1ac09
Compare
8a1ac09 to
62cc855
Compare
|
This looks nice 👍 Thanks for the config example in the description. This will help the Doc team when this feature has to be documented. |
4771a74 to
82bf885
Compare
82bf885 to
ffc1b35
Compare
c0d4bb5 to
36fa034
Compare
36fa034 to
56b993a
Compare
|
PR is ready. |
|
Nice! I love the idea 👍 |
|
Since creating HttpCache outside of the framework was done for perf purpose, I did some benchmarks.
|
chalasr
approved these changes
Jun 22, 2020
fabpot
approved these changes
Jun 22, 2020
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 23, 2020
…ing semantic configuration (nicolas-grekas) This PR was merged into the 5.2-dev branch. Discussion ---------- [FrameworkBundle] allow configuring trusted proxies using semantic configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - On top of the improved DX this should provide, this PR (and #37351) will allow [removing the corresponding lines](symfony/recipes#790) from `index.php` & recipes. Using values: ```yaml framework: trusted_proxies: '127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16' #or trusted_proxies: '%env(TRUSTED_PROXIES)%' ``` `trusted_headers` is similar but is an array of headers to trust. ```yaml framework: # that's the defaults already trusted_headers: ['x-forwarded-all', '!x-forwarded-host', '!x-forwarded-prefix'] ``` Commits ------- af9dd52 [FrameworkBundle] allow configuring trusted proxies using semantic configuration
stof
reviewed
Jun 26, 2020
| ->arrayNode('private_headers') | ||
| ->performNoDeepMerging() | ||
| ->requiresAtLeastOneElement() | ||
| ->fixXmlConfig('private_header') |
There was a problem hiding this comment.
this must be on the parent node to work
| ->integerNode('default_ttl')->end() | ||
| ->arrayNode('private_headers') | ||
| ->performNoDeepMerging() | ||
| ->requiresAtLeastOneElement() |
There was a problem hiding this comment.
why would we require at least one element here ?
Merged
fabpot
added a commit
that referenced
this pull request
Oct 16, 2020
…ion (nicolas-grekas) This PR was merged into the 5.x branch. Discussion ---------- [FrameworkBundle] fix config declaration of http_cache option | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Addresses comments from @stof in #37351 (review) Commits ------- 2514cf1 [FrameworkBundle] fix config declaration of http_cache option
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Oct 16, 2020
…ion (nicolas-grekas) This PR was merged into the 5.x branch. Discussion ---------- [FrameworkBundle] fix config declaration of http_cache option | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Addresses comments from @stof in symfony/symfony#37351 (review) Commits ------- 2514cf1c1d [FrameworkBundle] fix config declaration of http_cache option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, using the HTTP cache requires tweaking the
public/index.phpfile as explained in the doc.This PR removes this requirement by allowing one to do this instead: