Skip to content

Advanced exmple of Varnish settings #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pulzarraider opened this issue Jun 28, 2012 · 5 comments
Closed

Advanced exmple of Varnish settings #1505

pulzarraider opened this issue Jun 28, 2012 · 5 comments
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.

Comments

@pulzarraider
Copy link
Contributor

Documentation about Varnish settings should be expanded about prefered Varnish settings for basic Symfony project. This is very important, becuase Varnish ignores header cache-control: no-cache by default. And this header is returned by all Symfony pages which don't have any caching header set.
This makes problems in production, because Varnish starts to cache all pages that are generated by Symfony, which should not be cached.
@dbu dbu mentioned this issue Dec 11, 2014
Merged
@dbu
Copy link
Contributor

dbu commented Dec 11, 2014

@pulzarraider i think this basically has been present for a while already, but i clean up the varnish cookbook article in #4627 - glad if you can provide feedback in there.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 11, 2014
@javiereguiluz
Copy link
Member

Thanks to the great recent work made by David (@dbu) regarding Varnish docs, I think we could safely close this issue as solved.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@dbu opened some great pull requests yesterday (#4627 and #4628) which I would like to see merged before closing this.

weaverryan added a commit that referenced this issue Dec 22, 2014
@weaverryan
feature #4627 Rewrite the varnish cookbook article (dbu)
f4a7196 
This PR was merged into the 2.3 branch.

Discussion
----------

Rewrite the varnish cookbook article

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #1505, #4176

Commits
-------

dc9430a drop varnish 2 example from varnish cookbook article
9ea3671 Rewrite the varnish cookbook article
@weaverryan
Copy link
Member

I've just merged #4627, which talked about the cache-control portion. Technically, this issue has nothing to do with #4628, and since I'm certain we'll merge that soon anyways, let's close this - it staying open won't help us to not miss anything else :).

Thanks!

@pulzarraider
Copy link
Contributor Author

Thank you @dbu, @weaverryan. It's much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @dbu @weaverryan @pulzarraider @xabbuh