-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Console] Documenting the helpers #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll see what I can do |
@Sgoettschkes I already started working on this, maybe you can finish it and improve my text (as my english isn't very well): WouterJ/symfony-docs@add_console_helpers |
How would we collaborate on that? Do I fork your repository and then do a pull request on that one? |
I don't think you need to fork it, you can just pull that branch inside your symfony/symfony-docs fork and create a PR if you are finished. You can also start from stratch and use my branch as an 'example' or 'starting point' and do it your way. |
Of course I can just use another remote. For some reason I didn't think about this one. I'll have a look at it and improve where I see fit. I don't think there is a point in doing the work once more! |
@wouterj I just read your docs and added a few things. I ended up changing only minor parts as it was very well written (as far as I can say) and added the missing parts on the formatter helper: sgoettschkes/symfony-docs@4de636102bc04c9259d3cd9438c3b132817381ca |
@Sgoettschkes thank you, you did a great job too! Can you create a PR? |
Thanks to @Sgoettschkes, this is all documented now. But, I would like to move the Thanks! |
I guess with the latest PR being closed this one can be closed too @weaverryan |
ping @weaverryan |
I'll close this, as all helpers are documented right now (you can find those in |
The built-in console helpers should be documented
<info>foo</info>
by hand)the new 2.2 ProgressHelper is documented but it should probably be moved outside the introduction to the component to make it easier to find it.
The text was updated successfully, but these errors were encountered: