Skip to content

[HttpClient] Support file uploads by nesting resource streams in body option #18232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Apr 20, 2023 · 1 comment
Closed

[HttpClient] Support file uploads by nesting resource streams in body option #18232

fabpot opened this issue Apr 20, 2023 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. HttpClient
Milestone
6.3

Comments

@fabpot
Copy link
Member

fabpot commented Apr 20, 2023

Q A
Feature PR symfony/symfony#49911
PR author(s) @nicolas-grekas
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 6.3 milestone Apr 20, 2023
@OskarStark OskarStark changed the title [HttpClient] Support file uploads by nesting resource streams in body… [HttpClient] Support file uploads by nesting resource streams in body option Apr 20, 2023
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label May 22, 2023
@javiereguiluz javiereguiluz mentioned this issue May 22, 2023
Merged
javiereguiluz added a commit that referenced this issue May 23, 2023
@javiereguiluz
minor #18333 [HttpClient] Support file uploads by nesting resource st…
4d2a0e4 
…reams in body option (javiereguiluz)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[HttpClient] Support file uploads by nesting resource streams in body option

Fixes #18232.

I think that in the `versionadded` directive we should briefly mention the old way of doing things because it changes a lot from previous versions and this can confuse readers.

Commits
-------

3f996ca [HttpClient] Support file uploads by nesting resource streams in body option
@javiereguiluz
Copy link
Member

Fixed in #18333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpClient
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @carsonbot