Skip to content

[FrameworkBundle] Move Router cache directory to kernel.build_dir #19281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Dec 13, 2023 · 5 comments · Fixed by #19399
Closed

[FrameworkBundle] Move Router cache directory to kernel.build_dir #19281

fabpot opened this issue Dec 13, 2023 · 5 comments · Fixed by #19399
Labels
FrameworkBundle
Milestone
7.1

Comments

@fabpot
Copy link
Member

fabpot commented Dec 13, 2023

Q A
Feature PR symfony/symfony#52962
PR author(s) @Okhoshi
Merged in 7.1

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.1 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.1 milestone Dec 13, 2023
@alexandre-daubois
Copy link
Member

Had a look but it seems there's nothing to update here

@Okhoshi
Copy link
Contributor

Okhoshi commented Dec 13, 2023 •
edited
Loading

Thanks @alexandre-daubois for jumping on this so quickly 🙏

The only part I could see that would need an update is https://symfony.com/doc/current/reference/configuration/framework.html#cache-dir because the config is deprecated. I can take care of that update anyway :).

I now realize that one could set the cache_dir to null to disable the caching completely. I should reinstate that possibility.

@alexandre-daubois
Copy link
Member

alexandre-daubois commented Dec 13, 2023 •
edited
Loading

Ah yes, I missed this occurrence. PR always welcome if you're motivated to create it 🙂

@Okhoshi
Copy link
Contributor

Okhoshi commented Dec 13, 2023

I'll create the PR once symfony/symfony#53059 is merged :)

@alexandre-daubois
Copy link
Member

I think you can create the PR even without your last PR merged. Ping me if you need help/review 👍

@Okhoshi Okhoshi mentioned this issue Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle
Projects
None yet
Milestone
7.1
Development

Successfully merging a pull request may close this issue.

[FrameworkBundle] Update cache_dir config Okhoshi/symfony-docs
4 participants
@fabpot @alexandre-daubois @Okhoshi @carsonbot