Skip to content

[Serializer] Add context for CamelCaseToSnakeCaseNameConverter #19683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Mar 17, 2024 · 2 comments · Fixed by #19818
Closed

[Serializer] Add context for CamelCaseToSnakeCaseNameConverter #19683

fabpot opened this issue Mar 17, 2024 · 2 comments · Fixed by #19818
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer
Milestone
7.1

Comments

@fabpot
Copy link
Member

fabpot commented Mar 17, 2024

Q A
Feature PR symfony/symfony#53898
PR author(s) @AurelienPillevesse
Merged in 7.1

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.1 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.1 milestone Mar 17, 2024
@alexandre-daubois
Copy link
Member

alexandre-daubois commented Mar 27, 2024 •
edited
Loading

This should be put on hold, because the PR introduces a breaking change. The implementation is likely to change from what it is now.

@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2024

The BC break was fixed in symfony/symfony#54531.

mttsch added a commit to mttsch/symfony-docs that referenced this issue Apr 22, 2024
@mttsch
[Serializer] Add class/format/context to NameConverterInterface
9ea5c1c 
Fix symfony#19683
@mttsch mttsch mentioned this issue Apr 22, 2024
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 30, 2024
@wouterj wouterj closed this as completed in b53029a Dec 7, 2024
wouterj added a commit that referenced this issue Dec 7, 2024
@wouterj
feature #19818 [Serializer] Add class/format/context to NameConverter…
1082c01 
…Interface (mttsch)

This PR was merged into the 7.1 branch.

Discussion
----------

[Serializer] Add class/format/context to NameConverterInterface

Fix #19683

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).

-->

Commits
-------

b53029a [Serializer] Add class/format/context to NameConverterInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer
Projects
None yet
Milestone
7.1
Development

Successfully merging a pull request may close this issue.

[Serializer] Add class/format/context to NameConverterInterface mttsch/symfony-docs
4 participants
@fabpot @xabbuh @alexandre-daubois @carsonbot