Skip to content

Handle remaining, missing DIC Tags #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
17 tasks done
weaverryan opened this issue Mar 23, 2013 · 8 comments
Closed
17 tasks done

Handle remaining, missing DIC Tags #2347

weaverryan opened this issue Mar 23, 2013 · 8 comments
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection

Comments

@weaverryan
Copy link
Member

This is a summary of #519 and #1320.

DIC tags that are missing and need to be added:

  • assetic.filter from AsseticBundle
  • assetic.asset from AsseticBundle
  • assetic.formula_loader from AsseticBundle
  • assetic.formula_resource from AsseticBundle
  • assetic.factory_worker from AsseticBundle
  • assetic.templating.twig from AsseticBundle
  • assetic.templating.php from AsseticBundle
  • doctrine.event_subscriber from DoctrineBundle
  • doctrine.event_listener from DoctrineBundle

Changes specifically for Symfony 2.1:

  • kernel.cache_clearer
  • translation.dumper
  • translation.extractor
  • and remove security.listener.factory

Changes specificallt for Symfony 2.2:

  • kernel.fragment_renderer

We need to open up issues in the respective repositories of the bundles for the following tags (double-checking to see if they're already documented before creating an issue)

  • request.param_converter from SensioFrameworkExtraBundle
  • security.after_invocation.provider from JMSSecurityExtraBundle
  • security.secure_service from JMSSecurityExtraBundle
@iamdto
Copy link
Contributor

iamdto commented Mar 31, 2013

Looks like the kernel.fragment_renderer tag is missing too. It was introduced in 2.2 (I used it recently to override the hinclude fragment render).

@wouterj
Copy link
Member

wouterj commented Apr 3, 2013

The 2.1 specific 3th party bundle tags:

  • jms_aop.pointcut from JMSAopBundle (required by both JMS bundles)
  • security.expressions.function_compiler from JMSSecurityBundle
  • security.expressions.type_compiler from JMSSecurityBundle
  • security.expressions.variable from JMSSecurityBundle

@stof
Copy link
Member

stof commented Apr 3, 2013

@wouterj these should be documented in the JMS doc instead (which are rendered on jmsyst.com). They are not in the doc currently though

@wouterj
Copy link
Member

wouterj commented Apr 3, 2013

@stof yes, exactly. Just like the other ones at the end of Ryan's post. I mentioned it here to have one place with all missing tags that should be included in (a) the dic tag reference or (b) the docs of these almost-core bundles (which are included in the symfony site).

@wouterj
Copy link
Member

wouterj commented May 3, 2013

Both request.param_converter and security.secure_service are documented and I created an issue do security.after_invocation.provider ( schmittjoh/JMSSecurityExtraBundle#125 )

@xabbuh
Copy link
Member

xabbuh commented May 3, 2013

JMSDiExtraBundle and JMSSecurityExtraBundle are not part of the standard edition as of Symfony 2.3. We should take this into account, shouldn't we?

@wouterj
Copy link
Member

wouterj commented May 3, 2013

Yes, but they remain part of 2.1 and 2.2, so they still should get documented.

@wouterj
Copy link
Member

wouterj commented Jun 30, 2013

It is now finally fixed. Thank you @stof , @jalliot , @iamdto , @pvolok , @xabbuh and of course @weaverryan ! (Look how many people helped with this one! 👪 )

@wouterj wouterj closed this as completed Jun 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection
Projects
None yet
Development

No branches or pull requests

5 participants