Skip to content

Update HttpFoundation docs to reflect 2.4 changes #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
wouterj opened this issue Sep 10, 2013 · 3 comments
Closed
2 tasks done

Update HttpFoundation docs to reflect 2.4 changes #2958

wouterj opened this issue Sep 10, 2013 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) HttpFoundation
Milestone
2.4

Comments

@wouterj
Copy link
Member

wouterj commented Sep 10, 2013

The HttpFoundation component had some changes in 2.4:
@weaverryan
Copy link
Member

I'd like to add one, related to this, but really for HttpKernel:

  • Document the new FINISH_REQUEST event. This would be done in the HttpKernel component documentation at least. I'm not immediately sure if this is a useful event for developers, but it should be documented.

@wouterj
Copy link
Member Author

wouterj commented Sep 12, 2013

@weaverryan I created another issue for that (not sure why I didn't put it here...): #2959 And I know that @xabbuh is already working on documenting that :)

@xabbuh xabbuh mentioned this issue Sep 12, 2013
Merged
@weaverryan
Copy link
Member

The Request::getEncodings change has been merged. So this issue is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) HttpFoundation
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
2 participants
@weaverryan @wouterj