-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Form] Documentation of Collection Type #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stof If I read this correctly:
This is not regarding ne MyClassType(), it is regarding custom implementations with createBuilder() |
Yes, you're wrong. The |
For the reference, this issue is talking about "Allowing "new" tags with the "prototype"" of the /cookbook/form/form_collections article. This should be updated: The example should be changed (you can see an example of that in the first issue mentioned above). A |
I just wanted to verify if it actually a performance impact as it is described. If it is so it should be addressed. |
There is a performance impact. Whe you pass a type instance to the |
Closing it since as of 2.8 / 3.0 types will always be registered by the FQCN. |
As mentioned by @stof in symfony/symfony#9973 there is a performance impact by using a new form type as collection type. It is recommended to use a registered service as form type to take advantage of the performance improvements introduced with Symfony 2.1 (symfony/symfony#4882).
This should be verified and the collection documentation with the corresponding cookbook (embedding collections) should be updated with the recommended way.
The text was updated successfully, but these errors were encountered: