Skip to content

Possible "typo" #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ifdattic opened this issue Dec 28, 2014 · 2 comments
Closed

Possible "typo" #4696

ifdattic opened this issue Dec 28, 2014 · 2 comments

Comments

@ifdattic
Copy link
Contributor

English is not my native language or anything, but the bolded part of the following reads very strangely (wtf just goes through your head when reading it), so I think it might be a typo a could use a rewording (maybe it was supposed to be: than Twig templates).

Generally speaking, PHP templates are much more verbose than in Twig because they lack native support for lots of modern features needed by templates, like inheritance, automatic escaping and named arguments for filters and functions.

http://symfony.com/doc/current/best_practices/templates.html

@wouterj
Copy link
Member

wouterj commented Dec 28, 2014

yes, +1 for your suggestion. Can you submit a PR, then we can always see if @weaverryan merges it or not :)

@ifdattic
Copy link
Contributor Author

Done, ping @weaverryan @wouterj

weaverryan added a commit that referenced this issue Dec 29, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fix typo: than in Twig => than Twig templates

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #4696

Commits
-------

a8ec695 Fix typo: than in Twig => than Twig templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants