Skip to content

A typo in "The book, Chap2, page 19" #7202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MedUnes opened this issue Nov 30, 2016 · 7 comments
Closed

A typo in "The book, Chap2, page 19" #7202

MedUnes opened this issue Nov 30, 2016 · 7 comments
Labels
hasPR A Pull Request has already been submitted for this issue.
Milestone

Comments

@MedUnes
Copy link

MedUnes commented Nov 30, 2016

I think there is a typo in "The book, version 2.8" at Chapter2, Page19.

It have been stated:

"For organization, both controllers (formerly index.php and show.php) are now PHP functions and each has been moved into a separate file named controllers.php:",

while the context talks about list.php and show.php

I have attached a picture to illustrate this.
image

@MedUnes
Copy link
Author

MedUnes commented Nov 30, 2016

another typo at the same page:

But but careful not to confuse the terms

Should be:
But be careful not to confuse the terms.

image

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2016

Thank you for reporting these typos @MedUnes. I opened #7207 which fixes the second one. Though I do not fully understand which issue you see with your first example. Can you explain this with more details or describe what you would like to see instead?

@MedUnes
Copy link
Author

MedUnes commented Dec 1, 2016

The two controllers are (listAction() and showAction() ) so the sentence should have been written

"For organization, both controllers (formerly list.php and show.php) are now PHP functions and each has been moved into a separate file named controllers.php:",

instead of

"For organization, both controllers (formerly index.php and show.php) are now PHP functions and each has been moved into a separate file named controllers.php:",

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2016

But the filename used before on that page always was index.php when referring to the controller (list.php was only ever used for the template), wasn't it?

@MedUnes
Copy link
Author

MedUnes commented Dec 1, 2016

if so it might be, though the context is a bit confusing, it might need more precision.

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2016

Yeah, you might not be wrong. It's sometimes hard to tell that because of different perspectives. Do you have an idea how we could improve the current wording?

@javiereguiluz
Copy link
Member

I agree with @MedUnes and I've opened #7838 to fix the remaining issue.

@HeahDude HeahDude added the hasPR A Pull Request has already been submitted for this issue. label Apr 25, 2017
@HeahDude HeahDude added this to the 2.7 milestone Apr 25, 2017
xabbuh added a commit that referenced this issue Apr 27, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Minor reword to improve readability

This fixes #7202.

Commits
-------

425c83f Minor reword to improve readability
@xabbuh xabbuh closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

4 participants