Skip to content

Validator now supports DateTimeInterface instances for times #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jan 8, 2017 · 3 comments
Closed

Validator now supports DateTimeInterface instances for times #7333

javiereguiluz opened this issue Jan 8, 2017 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Milestone
3.3

Comments

@javiereguiluz
Copy link
Member

Added in symfony/symfony#21106
@javiereguiluz javiereguiluz added this to the 3.3 milestone Jan 8, 2017
@javiereguiluz
Copy link
Member Author

Closing it as "won't fix" because the current validator docs don't mention DateTime, so there's no need to mention that DateTimeInterface is also supported.

@xabbuh
Copy link
Member

xabbuh commented Jan 23, 2017

@javiereguiluz Imho we should reopen here. In the Time constraint reference we have the following sentence:

Validates that a value is a valid time, meaning either a DateTime object [...]

@xabbuh xabbuh reopened this Jan 23, 2017
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 23, 2017
@javiereguiluz javiereguiluz mentioned this issue Jan 23, 2017
Closed
@javiereguiluz
Copy link
Member Author

@xabbuh thanks! I've created #7405 for this.

@xabbuh xabbuh closed this as completed in 3872ec5 Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Mentioned that validator can validate DateTimeInterface too javiereguiluz/symfony-docs
2 participants
@javiereguiluz @xabbuh