Skip to content

[Console] Allow to catch CommandNotFoundException #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Apr 9, 2017 · 3 comments
Closed

[Console] Allow to catch CommandNotFoundException #7781

javiereguiluz opened this issue Apr 9, 2017 · 3 comments
Labels
Console good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
3.3

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#22181

Review if we mention that you can't catch CommandNotFoundException. If we do, fix it.
@javiereguiluz javiereguiluz added Console good first issue Ideal for your first contribution! (some Symfony experience may be required) Missing Documentation labels Apr 9, 2017
@javiereguiluz javiereguiluz added this to the 3.3 milestone Apr 9, 2017
@xabbuh
Copy link
Member

xabbuh commented Apr 10, 2017

Closing as we do not mention the CommandNotFoundException anywhere.

@xabbuh xabbuh closed this as completed Apr 10, 2017
@javiereguiluz
Copy link
Member Author

Have you also checked if we mention this limitation with words? Instead of using CommandNotFoundException explicitly maybe we say: "you can catch all exceptions except when the command itself is not found".

@xabbuh
Copy link
Member

xabbuh commented Apr 10, 2017

@javiereguiluz Yes, at least if I did not miss any other place in the docs talking about exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@javiereguiluz @xabbuh