Skip to content

[VarDumper] Add filter in VarDumperTestTrait #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jul 16, 2017 · 1 comment
Closed

[VarDumper] Add filter in VarDumperTestTrait #8172

javiereguiluz opened this issue Jul 16, 2017 · 1 comment
Labels
bug hasPR A Pull Request has already been submitted for this issue. Status: Needs Review VarDumper
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#22588.

assertDumpEquals() and assertDumpMatchesFormat() now define a new argument to filter things. Check if we use them in any code sample.
@javiereguiluz javiereguiluz added this to the 3.4 milestone Jul 16, 2017
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jul 21, 2017
@xabbuh xabbuh mentioned this issue Jul 21, 2017
Merged
@xabbuh
Copy link
Member

xabbuh commented Jul 21, 2017

see #8207

javiereguiluz added a commit that referenced this issue Jan 12, 2018
@javiereguiluz
minor #8207 add filter argument to assertDumpEquals() (xabbuh)
2a11e79 
This PR was merged into the 3.4 branch.

Discussion
----------

add filter argument to assertDumpEquals()

This fixes #8172.

Commits
-------

671fa2c add filter argument to assertDumpEquals()
@xabbuh xabbuh closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hasPR A Pull Request has already been submitted for this issue. Status: Needs Review VarDumper
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @carsonbot