[VarDumper] Add filter in VarDumperTestTrait #22588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: in sf 4.0, methods signatures should be more elegant with // sf 3.x
public function assertDumpEquals($dump, $data, $message = '', $filter = 0)
public function assertDumpMatchesFormat($dump, $data, $message = '', $filter = 0)
// sf 4.0
public function assertDumpEquals($dump, $data, $filter = 0, $message = '')
public function assertDumpMatchesFormat($dump, $data, $filter = 0, $message = '') |
|
That's not possible without an upgrade path: we don't do hard BC breaks without notices first in 3.4. |
|
Like this? @trigger_error(sprintf('The $filter parameter of the %s() is deprecated since version 3.4 and will be moved at 3rd position in 4.0.', __METHOD__), E_USER_DEPRECATED); |
2768296 to
7fea536
Compare
|
@maidmaid you could detect when the type is int vs string and trigger a deprecation like in your example when relevant. |
|
Ok @nicolas-grekas, I will do this in an other PR. |
|
I'd prefer in the same PR, that's the same "unit of work" to me. |
dd48f24 to
9525b9a
Compare
|
Deprecation added. |
9525b9a to
1da8e71
Compare
fabpot
approved these changes
Jul 3, 2017
|
Thank you @maidmaid. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 3, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Add filter in VarDumperTestTrait | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | / | License | MIT | Doc PR | / Many casters uses ``EXCLUDE_*`` flags in their cast method. It would be usefull to use this flags directly with ``VarDumperTestTrait`` to tests many cases. Commits ------- 1da8e71 Add filter in VarDumperTestTrait
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2017
…idmaid) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Test ExceptionCaster excluding verbosity | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / Cover better ``ExceptionCaster`` in tests thanks to filter which was added in #22588. Commits ------- 85766c9 Add exculde verbosity test
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2017
…aidmaid) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Test ReflectionCaster excluding verbosity | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / Cover better ``ReflectionCaster`` in tests thanks to ``EXCLUDE_*`` filter which was added in #22588. Commits ------- e535089 Add exculde verbosity test
symfony-splitter
pushed a commit
to symfony/var-dumper
that referenced
this pull request
Jul 11, 2017
…aidmaid) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Test ReflectionCaster excluding verbosity | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / Cover better ``ReflectionCaster`` in tests thanks to ``EXCLUDE_*`` filter which was added in symfony/symfony#22588. Commits ------- e535089 Add exculde verbosity test
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many casters uses
EXCLUDE_*flags in their cast method. It would be usefull to use this flags directly withVarDumperTestTraitto tests many cases.