Skip to content

Misleading documentation #8771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oppodelldog opened this issue Nov 29, 2017 · 2 comments
Closed

Misleading documentation #8771

Oppodelldog opened this issue Nov 29, 2017 · 2 comments
Labels
BrowserKit bug hasPR A Pull Request has already been submitted for this issue. Status: Needs Review

Comments

@Oppodelldog
Copy link

The documentation of the BrowserKit Client is someway misleading.
I wanted to use the BrowserKit Client to make a real call to a public webseite, but that does not work out of the box. Always my application is triggered.

There is a comment in the documentation of the "History" feature which let me assume how external calls would have been possible. But the request related code does not differ from some code abouve that does not state to "make a real request to an external site".

So I would suggest to remove that comment. The code is better readable without it.

https://github.com/symfony/symfony-docs/blame/4.0/components/browser_kit.rst#L202

@weaverryan
Copy link
Member

Yea... the Client isn't really meant to make requests to external sites. Is it even possible? Does the code that @Oppodelldog linked to even work? I agree that something should probably be removed.

@javiereguiluz javiereguiluz added bug hasPR A Pull Request has already been submitted for this issue. labels Dec 4, 2017
@javiereguiluz
Copy link
Member

I think this is a bug. We're trying to fix it in #8823. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BrowserKit bug hasPR A Pull Request has already been submitted for this issue. Status: Needs Review
Projects
None yet
Development

No branches or pull requests

5 participants