Skip to content

[HttpFoundation] Allow DateTimeImmutable in Response setters #9024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jan 8, 2018 · 0 comments · Fixed by #9045
Closed

[HttpFoundation] Allow DateTimeImmutable in Response setters #9024

javiereguiluz opened this issue Jan 8, 2018 · 0 comments · Fixed by #9045
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

This won't need big changes ... but let's review if we mention somewhere that we don't support immutable dates. See symfony/symfony#24677
@javiereguiluz javiereguiluz added this to the 4.1 milestone Jan 8, 2018
@Simperfit Simperfit mentioned this issue Jan 12, 2018
Merged
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 12, 2018
javiereguiluz added a commit that referenced this issue Jan 13, 2018
@javiereguiluz
minor #9045 [HttpFoundation] Add a doc entry since Response's methods…
a0290a1 
… now accept immutable date objects (Simperfit, javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

[HttpFoundation] Add a doc entry since Response's methods now accept immutable date objects

fixes #9024

Commits
-------

82ea3ac Added the new doc in a note
dbcfb85 [HttpFoundation] Add a doc entry since Response's methods now accept immutable object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
4.1
1 participant
@javiereguiluz