Skip to content

Update doc to avoid bundle:controller:action and service:method controller syntax #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tobion opened this issue Feb 21, 2018 · 0 comments · Fixed by #9468
Closed

Update doc to avoid bundle:controller:action and service:method controller syntax #9306

Tobion opened this issue Feb 21, 2018 · 0 comments · Fixed by #9468
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
4.1

Comments

@Tobion
Copy link
Contributor

Tobion commented Feb 21, 2018

With symfony/symfony#26085 coming with Symfony 4.1 the doc should not mention the deprecated syntax anymore. Most examples in the doc already use the FQCN::method syntax which is good. The parts I've found that should be updated are

If your controller is registered as a service, you can also use just one colon separator (e.g. service_name:index).
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Feb 23, 2018
@javiereguiluz javiereguiluz added this to the 4.1 milestone Mar 20, 2018
@Chris-Bitler Chris-Bitler mentioned this issue Mar 22, 2018
Merged
Chris-Bitler pushed a commit to Chris-Bitler/symfony-docs that referenced this issue Mar 22, 2018
Remove docs about service_name:method
a5a5ad7 
It is deprecated as of 4.1.
Fixes symfony#9306
javiereguiluz added a commit that referenced this issue Mar 22, 2018
@javiereguiluz
minor #9468 Remove docs about service_name:method (Chris-Bitler)
8e64505 
This PR was merged into the master branch.

Discussion
----------

Remove docs about service_name:method

The 'service_name:method' syntax is deprecated as of 4.1

This fixes #9306.

Commits
-------

a5a5ad7 Remove docs about service_name:method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Remove docs about service_name:method Chris-Bitler/symfony-docs
3 participants
@javiereguiluz @Tobion @xabbuh