Skip to content

Add necessary call to Form::isSubmitted and remove boilerplate #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add necessary call to Form::isSubmitted and remove boilerplate #10068

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c423a0f
Add necessary call to Form::isSubmitted and remove boilerplate
keichinger Jul 14, 2018
08c177a
Minor refactor
javiereguiluz Jul 23, 2018
1ed7a33
Update form_collections.rst
javiereguiluz Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions form/form_collections.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,12 +655,9 @@ the relationship between the removed ``Tag`` and ``Task`` object.
use Doctrine\Common\Collections\ArrayCollection;

// ...
public function edit($id, Request $request)
public function edit($id, Request $request, EntityManagerInterface $entityManager)
{
$entityManager = $this->getDoctrine()->getManager();
$task = $entityManager->getRepository(Task::class)->find($id);

if (!$task) {
if (null === $task = $entityManager->getRepository(Task::class)->find($id)) {
throw $this->createNotFoundException('No task found for id '.$id);
}

Expand All @@ -675,8 +672,7 @@ the relationship between the removed ``Tag`` and ``Task`` object.

$editForm->handleRequest($request);

if ($editForm->isValid()) {

if ($editForm->isSubmitted() && $editForm->isValid()) {
// remove the relationship between the tag and the Task
foreach ($originalTags as $tag) {
if (false === $task->getTags()->contains($tag)) {
Expand Down