[Validator] Document the DivisibleBy constraint #10121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jul 26, 2018
|
The constraint has been renamed, so I've updated the documentation accordingly. |
OskarStark
approved these changes
Aug 10, 2018
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Aug 15, 2018
…ivisibility (colinodell) This PR was squashed before being merged into the 4.2-dev branch (closes #28069). Discussion ---------- [Validator] New `DivisibleBy` constraint for testing divisibility This introduces a new ~`MultipleOf`~ `DivisibleBy` constraint which checks whether one number is a multiple of (aka "divisible by") some other number. Useful for enforcing specific increments on a number. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#10121 See symfony/symfony-docs#10121 for examples of this constraint in action. Commits ------- efcfb8b22d [Validator] New `DivisibleBy` constraint for testing divisibility
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 15, 2018
…ivisibility (colinodell) This PR was squashed before being merged into the 4.2-dev branch (closes #28069). Discussion ---------- [Validator] New `DivisibleBy` constraint for testing divisibility This introduces a new ~`MultipleOf`~ `DivisibleBy` constraint which checks whether one number is a multiple of (aka "divisible by") some other number. Useful for enforcing specific increments on a number. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#10121 See symfony/symfony-docs#10121 for examples of this constraint in action. Commits ------- efcfb8b [Validator] New `DivisibleBy` constraint for testing divisibility
javiereguiluz
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
@colinodell thanks a lot for providing this new constraint and for documenting it too. Sadly there are some merge conflicts. Could you please fix them? Thanks!
|
Thanks for the heads-up @javiereguiluz! Looks like the |
|
It's merged now. Thanks Colin! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 6, 2018
…ell) This PR was merged into the master branch. Discussion ---------- [Validator] Document the DivisibleBy constraint Documentation for the new ~`MultipleOf`~ `DivisibleBy` constraint proposed in symfony/symfony#28069 Commits ------- 3270cca Document the DivisibleBy constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the new
MultipleOfDivisibleByconstraint proposed in symfony/symfony#28069