Skip to content

Fix docs on trusted hosts #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix docs on trusted hosts #10138

wants to merge 2 commits into from

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 1, 2018

Trusted hosts are always regular expressions.

nicolas-grekas
nicolas-grekas reviewed Aug 1, 2018
View reviewed changes
reference/configuration/framework.rst Outdated
Hosts can also be configured using regular expressions (e.g. ``^(.+\.)?example.com$``),
which make it easier to respond to any subdomain.
Hosts can also be configured to respond to any subdomain, via
``^(.+\.)?example\.com$`` for isntance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for instance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xabbuh xabbuh added this to the 2.8 milestone Aug 3, 2018
@xabbuh
Copy link
Member

xabbuh commented Aug 4, 2018

Thank you @fabpot.

xabbuh added a commit that referenced this pull request Aug 4, 2018
@xabbuh
minor #10138 Fix docs on trusted hosts (fabpot)
2c280ba 
This PR was squashed before being merged into the 2.8 branch (closes #10138).

Discussion
----------

Fix docs on trusted hosts

Trusted hosts are always regular expressions.

Commits
-------

e2744ad Fix docs on trusted hosts
@xabbuh xabbuh closed this Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@fabpot @xabbuh @nicolas-grekas @carsonbot