-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
stop using the deprecated @method annotation #10150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe it would be simpler to cherry pick #8016? Some changes are missing imo, like https://github.com/symfony/symfony-docs/pull/8016/files#diff-8dd5da38c8cf3dec783e2e5247682043L130, https://github.com/symfony/symfony-docs/pull/8016/files#diff-54df5b9457e71c9f4a6cd1e3522a12c1R194, but globally this is a good move 👍 |
@GuilhemN Ah, I forgot that we already made the change for the 3.4 docs in the past. @HeahDude @javiereguiluz @weaverryan @wouterj Do you agree with backporting #8016? |
I don't remember why we didn't that change in 2.8. Maybe the merge was too conflicting or maybe we prefer to keep that old doc related to the old SensioFrameworkExtraBundles? After all, if you are reading Symfony 2.8 docs today, you are probably working on a legacy app, so I'm not sure if the new ExtraBundle version is going to be available. |
The only use case where you need the I think the reason we did this change only for 3.4+ was that this was the first version where even using controllers as services with the built-in |
I'm confused: in #8016, we made the change because this was a new feature added to Symfony 3.4. Does it work on 2.8? Also, in the original issue - #10142, the user IS using Symfony 3.4. The real problem was that the deprecation notice wasn't obvious:
The user wasn't sure what happened to Or, did I miss something? :) |
I was confused too so I took another look. We can indeed not use the |
updated here to only replace usages of the |
Thanks Christian. |
This PR was merged into the 2.8 branch. Discussion ---------- stop using the deprecated @method annotation I think we should use the `@Route` annotation from the Routing component instead of the one from SensioFrameworkExtraBundle (fixes #10142). Commits ------- 4e1496d stop using the deprecated @method annotation
I think we should use the
@Route
annotation from the Routing component instead of the one from SensioFrameworkExtraBundle (fixes #10142).