Skip to content

action_method is missing $task variable #10200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TomasVotruba
Copy link

It's not clear from the docs, but user has to first create the $task variable.

In the second example bellow it's more clear thanks to // ....

This makes it a bit more explicit here as well.

It's not clear from the docs, but user has to first create the `$task` variable.

In the second example bellow it's more clear thanks to `// ...`.

This makes it a bit more explicit here as well.
@xabbuh
Copy link
Member

xabbuh commented Aug 21, 2018

Thank you @TomasVotruba.

xabbuh added a commit that referenced this pull request Aug 21, 2018
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #10200).

Discussion
----------

action_method is missing $task variable

It's not clear from the docs, but user has to first create the `$task` variable.

In the second example bellow it's more clear thanks to `// ...`.

This makes it a bit more explicit here as well.

Commits
-------

5ada0ef action_method is missing $task variable
xabbuh added a commit that referenced this pull request Aug 21, 2018
@xabbuh xabbuh closed this Aug 21, 2018
@TomasVotruba TomasVotruba deleted the patch-2 branch August 21, 2018 11:46
weaverryan added a commit that referenced this pull request Aug 28, 2018
* 2.8:
  {% if label is not same as(false) and required %}
  Shorten ternary operator
  Fix wrong usage in custom authenticator checking if password is invalid
  update hardcoded 5.1 version link
  Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
  Update bugs.rst
  [#10200] remove trailing spaces
  action_method is missing $task variable
  Fix bad link
weaverryan added a commit that referenced this pull request Aug 28, 2018
* 3.4:
  {% if label is not same as(false) and required %}
  Update service_container.rst
  Shorten ternary operator
  Fix wrong usage in custom authenticator checking if password is invalid
  [Process] Fix typo in Process object initialization
  update hardcoded 5.1 version link
  Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
  Update bugs.rst
  [#10200] remove trailing spaces
  action_method is missing $task variable
  Fix bad link
weaverryan added a commit that referenced this pull request Aug 28, 2018
* 4.1:
  {% if label is not same as(false) and required %}
  minor language tweak
  Update service_container.rst
  Fix wrong exception used in custom authentication provider example
  [Console] Replace useless usage of ContainerAwareCommand
  Shorten ternary operator
  Fix wrong usage in custom authenticator checking if password is invalid
  [Process] Fix typo in Process object initialization
  update hardcoded 5.1 version link
  Explain dump server usage outside of Symfony
  Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
  Update bugs.rst
  [#10200] remove trailing spaces
  action_method is missing $task variable
  [#10177] fix markup
  Clarifying when you need to or don't need to install the server bundle
  Fix bad link
  Update setup.rst
  Also requiring annotations so they can be used
royklutman pushed a commit to royklutman/symfony-docs that referenced this pull request Sep 21, 2018
royklutman added a commit to royklutman/symfony-docs that referenced this pull request Sep 21, 2018
Guikingone pushed a commit to Guikingone/symfony-docs that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants