-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
extend profiler article about how to use the stopwatch #10332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alternative to #9320, was suggested there |
fd2f75d
to
5f01600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the contribution 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the build is failing because stopwatch.rst
is not being included anywhere:
/home/travis/build/symfony/symfony-docs/profiler/stopwatch.rst:: WARNING: document isn't included in any toctree
Can you include it in profiler.rst
the same as the other profiler docs?
6b0fb7a
to
cfd55e3
Compare
cfd55e3
to
93b6111
Compare
Finally done. The bot is pleased. Sorry for force-pushing this often. I first did not know how to resolve the merge conflict. |
What does failure of |
Do you want to update profiler.rst to have a link to stopwatch.rst? |
Thank you for the PR. Do you think we still need it now that #10259 is merged? |
The profiler page would be nice since this is the place I would probably start searching. (Suggested to place the info there in #9320 (review).) But duplicating the information is no help, a link is sufficient. summary of historyWell, not sure anymore how history was. I made several PR concerning this topic: I guess I created #10259 without remembering the first PR. And having forgotten to mention it when replacing the 1st one. So there were probably two plans... |
@SimonHeimberg thanks for this contribution! You are right that this is a bit confusing and it's not easy to know where to put things. So, in #10970 we're revamping the main Profiler article. I've been inspired by your work here to create a section about the Stopwatch integration in the profiler. so, we can close this in favor of #10970. Thanks! |
No description provided.